Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-16887

Only last custom tag of type link created works

    Details

      Description

      When you add multiple custom tags with attribute of type "link", only the last inserted works. For all the others an click on Search, Browse or Bookmarks has no effects at all.

      Steps to reproduce

      Add 2 custom tags with an attribute of type "link", ie "testlink1" and "testlink2"
      Create a content with an online editor and try to add a custom tag testlink1.

      When you click on one of the buttons (Search content / Browse / Bookmarks) nothing happens

      Change custom tag to "testlink2", now you can click on buttons Search content / Browse / Bookmarks and it works

        Issue Links

          Activity

          Hide
          Charlotte REYMOND added a comment -

          Forgot the environment :

          Operating system : linux debian 32B
          PHP version : 5.2.10
          Browser : Firefox 3.6, Chrome, Internet explorer 7

          Show
          Charlotte REYMOND added a comment - Forgot the environment : Operating system : linux debian 32B PHP version : 5.2.10 Browser : Firefox 3.6, Chrome, Internet explorer 7
          Hide
          Sylvain Bannier added a comment -

          Reason :
          The same javascript variable is used to set every link attribute in every custom tags. So the last one overrides the previous ones.

          Adding attibute id in "ezoeLinkAttribute" variable partially fixes the bug (see attached diff of extension/ezoe/design/standard/templates/ezoe/customattributes/link.tpl ) but then user is unable to select any node in the "slide" panel.

          Show
          Sylvain Bannier added a comment - Reason : The same javascript variable is used to set every link attribute in every custom tags. So the last one overrides the previous ones. Adding attibute id in "ezoeLinkAttribute" variable partially fixes the bug (see attached diff of extension/ezoe/design/standard/templates/ezoe/customattributes/link.tpl ) but then user is unable to select any node in the "slide" panel.
          Hide
          André R added a comment -

          Confirmed, this is a know limitation and should have been documented.

          Show
          André R added a comment - Confirmed, this is a know limitation and should have been documented.
          Hide
          André R added a comment -

          To expand:

          • it's currently not technically supported to have several links on one tag
          • same limitations applies to custom tags + td/tr, since they share gui, only one of them can have link attribute currently

          Will look into it soon (next few weeks during 4.4 bug fixing period)

          Show
          André R added a comment - To expand: it's currently not technically supported to have several links on one tag same limitations applies to custom tags + td/tr, since they share gui, only one of them can have link attribute currently Will look into it soon (next few weeks during 4.4 bug fixing period)
          Hide
          André R added a comment -
          Show
          André R added a comment - Initial fix for testing commited to master: http://github.com/ezsystems/ezoe/commit/a96a47ca657a0a5e403a273b6a0a86b2aa04f8eb
          Show
          André R added a comment - Fix in master tested and found working, merged to stable-5.2: http://github.com/ezsystems/ezoe/commit/2b6b85180825a3da761ed8998db3a3b9b70de631 and stable-5.1: http://github.com/ezsystems/ezoe/commit/ada56711ae305194ed64dd22c7c27212310aeeb8

            People

            • Assignee:
              André R
              Reporter:
              Charlotte REYMOND
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: