If the user object is stored, but the publishing fails, this is not detected. The activation email will be sent, and will appear OK, since it takes its content from the user object. The user node however does not exist, so the user can't login and the admin can't find the user by searching.
The patch solves this by stopping execution when publishing fails. The standard warning "Unable to register new user" (already existing in templates) will be shown.