Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-16503

TC-80: Sending information collection form is broken in admin2

    Details

      Description

      Hi,

      When we press the "send" button to send an email, within a content based on a class that has attributes that collects information, the "send" button doesn't work on the new interface.
      The same test was done on the 'old' interface and everything seems to work right.

      In attach there is a capture of a screen of the result on the new interface.

      Steps to reproduce

      Create information collection class
       
         1. Log in as admin in admin
         2. Click "Setup" in top menu
         3. Click "Classes" in left menu
         4. Click "Content" link in class group list
         5. Click "New class" link
         6. Enter form data:
            Name : tContact
            Identifier : tcontact
            Object name pattern : <tname>
         7. Add "Text line" attribute :
            Required : yes
            Name : Name
            Identifier : tname
         8. Add "Text line" attribute :
            Required : yes
            Searchable : no
            Information collector : yes
            Name : Subject
            Identifier : tsubject
         9. Add "Text block" attribute :
            Required : yes
            Searchable : no
            Information collector : yes
            Name : Message
            Identifier : tmessage
        10. Add "Text block" attribute :
            Required : yes
            Searchable : no
            Information collector : yes
            Name : Your email address
            Identifier : temail
        11. Click "OK" button
       
      Create Information collector object
       
         1. Click "Content structure"
         2. Create a "tContact" object:
            Name : Contact form
         3. Click "Send for publishing" button
       
      Test information collection
       
         1. Click "Contact form" link
         2. Click the "Preview" bar
         3. Enter formdata :
            Subject : test1
            Message : This is my message
            Your email adrresse : test123@test.com
       
      Verify the result
       
         1. Verify that you are represented a page with this information:
            Subject : test1
            Message : This is my message
            Your email adrresse : test123@test.com
         2 .Press "send" button
      

        Activity

        Paulo Cardiga created issue -
        Hide
        André R added a comment -

        This is caused by the fact that content preview is no longer inside the <form> tag that the send button is (custom action)

        Show
        André R added a comment - This is caused by the fact that content preview is no longer inside the <form> tag that the send button is (custom action)
        Hide
        André R added a comment - - edited

        In reply to comment #051278
        Possible patch (moves buttons inside preview box and adds a form there) attached.

        BUT, this breaks the actions of ezcomment witch does not use ContentActions, so addotionally the following should be done for 4.4 (oms approved):

        • Generalize ContentActions so you can provide info to content/action on where to redirect to (for instance action_redirect) so we don't have to hardcode these actions in content/action
        • Add support for it in ezcomment so it does not have it's own form (form's inside forms is not valid html and does not work)016503_infocollector_admin2.diff
        Show
        André R added a comment - - edited In reply to comment #051278 Possible patch (moves buttons inside preview box and adds a form there) attached. BUT, this breaks the actions of ezcomment witch does not use ContentActions, so addotionally the following should be done for 4.4 (oms approved): Generalize ContentActions so you can provide info to content/action on where to redirect to (for instance action_redirect) so we don't have to hardcode these actions in content/action Add support for it in ezcomment so it does not have it's own form (form's inside forms is not valid html and does not work) 016503_infocollector_admin2.diff
        Hide
        André R added a comment -

        016503_infocollector_admin2.diff patch for trunk (4.3.0 / 4.4.0alpha1)

        Show
        André R added a comment - 016503_infocollector_admin2.diff patch for trunk (4.3.0 / 4.4.0alpha1)
        Hide
        André R added a comment -

        Fixed in master:
        http://github.com/ezsystems/ezpublish/commit/25627c145a46b7ba9b1b2123922db2239a0a869c
        And stable 4.3:
        http://github.com/ezsystems/ezpublish/commit/da541ddf25b3a50269c2c00c555e094878af37f5

        @doc: As part of this 4.4.0 got a new feature to make it possible for ezcomments to use some thing called custom actions on datatypes.
        New setting in datatype.ini/[ViewSettings]:

        # List of custom datatype actions and corresponding <module>/<view> or
        # just <view> in case of content module where they should be executed
        # eg: CustomActionMap[ActionAddToBasket]=shop/basket
        # eg: CustomActionMap[ActionCollectInformation]=collectinformation
        # Note: Action definition should be defined in contentActionList function
        # of the datatype, see ez[multi]pricetype.php for code example.
        CustomActionMap[]
        

        The code examples are not something we have in online doc, it's just a hint to developers to know where to look.

        Show
        André R added a comment - Fixed in master: http://github.com/ezsystems/ezpublish/commit/25627c145a46b7ba9b1b2123922db2239a0a869c And stable 4.3: http://github.com/ezsystems/ezpublish/commit/da541ddf25b3a50269c2c00c555e094878af37f5 @doc: As part of this 4.4.0 got a new feature to make it possible for ezcomments to use some thing called custom actions on datatypes. New setting in datatype.ini/ [ViewSettings] : # List of custom datatype actions and corresponding <module>/<view> or # just <view> in case of content module where they should be executed # eg: CustomActionMap[ActionAddToBasket]=shop/basket # eg: CustomActionMap[ActionCollectInformation]=collectinformation # Note: Action definition should be defined in contentActionList function # of the datatype, see ez[multi]pricetype.php for code example. CustomActionMap[] The code examples are not something we have in online doc, it's just a hint to developers to know where to look.
        Show
        Geir Arne Waaler added a comment - This has been documented here: http://ez.no/doc/ez_publish/technical_manual/4_x/reference/configuration_files/datatype_ini/viewsettings/customactionmap Geir Arne Waaler
        Hide
        ezrobot added a comment -

        This issue has been automatically closed due to the lack of activity over a long period of time. It is very likely that it is obsolete, but if you think it is still valid, do not hesitate to reopen it and mention why.

        Show
        ezrobot added a comment - This issue has been automatically closed due to the lack of activity over a long period of time. It is very likely that it is obsolete, but if you think it is still valid, do not hesitate to reopen it and mention why.
        André Rømcke made changes -
        Field Original Value New Value
        Workflow eZ Community Workflow [ 28994 ] eZ Engineering Scrumban Workflow [ 46162 ]
        André Rømcke made changes -
        Workflow eZ Engineering Scrumban Workflow [ 46162 ] EZ* Development Workflow [ 80610 ]
        Alex Schuster made changes -
        Workflow EZ* Development Workflow [ 80610 ] EZEE Development Workflow [ 119188 ]

          People

          • Assignee:
            André R
            Reporter:
            Paulo Cardiga
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: