Details

      Description

      Each item of an RSS feed should have a guid element.
      Node's remote id would be a good guid.

      http://validator.w3.org/feed/docs/warning/MissingGuid.html

      1. rss_guid.diff
        0.5 kB
        Damien Pobel
      2. rssGUIDfix.diff
        1 kB
        Erwin Eggenberger

        Issue Links

          Activity

          Hide
          Damien Pobel added a comment -

          Attached very small patch against trunk

          Show
          Damien Pobel added a comment - Attached very small patch against trunk
          Hide
          Knut Urdalen added a comment -

          I can verify this issue and manually tested the supplied patch with eZRSSExport::fetchRSS2_0().

          The fix should be applied to both eZRSSExport::fetchRSS2_0() and eZRSSExport::fetchRSS1_0().

          Show
          Knut Urdalen added a comment - I can verify this issue and manually tested the supplied patch with eZRSSExport::fetchRSS2_0(). The fix should be applied to both eZRSSExport::fetchRSS2_0() and eZRSSExport::fetchRSS1_0().
          Hide
          Jostein- Knudsen added a comment - - edited

          I think this text may be valid in relation to this issue:

          http://cyber.law.harvard.edu/rss/rss.html#comments
          "A frequently asked question about <guid>s is how do they compare to <link>s. Aren't they the same thing? Yes, in some content systems, and no in others. In some systems, <link> is a permalink to a weblog item. However, in other systems, each <item> is a synopsis of a longer article, <link> points to the article, and <guid> is the permalink to the weblog entry. In all cases, it's recommended that you provide the guid, and if possible make it a permalink. This enables aggregators to not repeat items, even if there have been editing changes."

          update: this is the same text as Damien links to...

          Show
          Jostein- Knudsen added a comment - - edited I think this text may be valid in relation to this issue: http://cyber.law.harvard.edu/rss/rss.html#comments "A frequently asked question about <guid>s is how do they compare to <link>s. Aren't they the same thing? Yes, in some content systems, and no in others. In some systems, <link> is a permalink to a weblog item. However, in other systems, each <item> is a synopsis of a longer article, <link> points to the article, and <guid> is the permalink to the weblog entry. In all cases, it's recommended that you provide the guid, and if possible make it a permalink. This enables aggregators to not repeat items, even if there have been editing changes." update: this is the same text as Damien links to...
          Hide
          Ole Morten Halvorsen added a comment -

          fixed in
          trunk (4.1.0alpha1) rev. 22545
          stable/4.0 (4.0.2) rev. 22546

          Show
          Ole Morten Halvorsen added a comment - fixed in trunk (4.1.0alpha1) rev. 22545 stable/4.0 (4.0.2) rev. 22546
          Hide
          Erwin Eggenberger added a comment -

          Hi,

          I think the patch by Damien helps to satisfy the validator, but it doesn't solve the real problem.
          From the W3C Message Damien posted a link to:
          "It's recommended that you provide the guid, and if possible make it a permalink. This enables aggregators to not repeat items, even if there have been editing changes."
          Reusing the link value for the guid doesn't solve this, since the URL alias can change. I've attached a patch that uses the system URL for the guid. When using the system URL as guid you won't get duplicate entries in aggregators when the URL alias of a node changes.

          rssGUIDfix.diff

          Show
          Erwin Eggenberger added a comment - Hi, I think the patch by Damien helps to satisfy the validator, but it doesn't solve the real problem. From the W3C Message Damien posted a link to: "It's recommended that you provide the guid, and if possible make it a permalink. This enables aggregators to not repeat items, even if there have been editing changes." Reusing the link value for the guid doesn't solve this, since the URL alias can change. I've attached a patch that uses the system URL for the guid. When using the system URL as guid you won't get duplicate entries in aggregators when the URL alias of a node changes. rssGUIDfix.diff
          Hide
          Damien Pobel added a comment -

          Hi,

          I think that exposing the system URL is a very bad idea from a SEO point of view, it will give 2 URIs for the same page.
          Moreover, your patch will not work as

          1. it lacks a $
          2. you copy a buggy code from eZ I just discovered from your input (see http://issues.ez.no/14409)

          And after some reflexions, the system URI doesn't really identified the content as the same content can be in many locations (the same goes for node's remote id I mentioned in the initial bug report), the only things that can really identify a content is the remote id of the content object or perhaps the system URL of the main location (but it can change for the same content).

          Show
          Damien Pobel added a comment - Hi, I think that exposing the system URL is a very bad idea from a SEO point of view, it will give 2 URIs for the same page. Moreover, your patch will not work as it lacks a $ you copy a buggy code from eZ I just discovered from your input (see http://issues.ez.no/14409 ) And after some reflexions, the system URI doesn't really identified the content as the same content can be in many locations (the same goes for node's remote id I mentioned in the initial bug report), the only things that can really identify a content is the remote id of the content object or perhaps the system URL of the main location (but it can change for the same content).
          Hide
          Erwin Eggenberger added a comment -

          Hi Damien,

          you are right, my code lacks a $. I've never tested it with URL translation disabled, but regarding the other bug you've just found, rss exports probably were never tested without URL translation before

          If you are worried about the SEO impact of using the system URL, you can set isPermaLink="false" and use just the ID. See http://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
          You could also redirect system URLs to the translated urls.

          But to be honest, I'm also not sure what would be best to use as guid. Our problem was that our readers got duplicate entries in their news aggregators, and using the translated URL as guid didn't solve this problem. Using the node ID works fine for us, since our rss exports use only one source and we don't use multiple locations for objects.

          Regards,

          Erwin

          Show
          Erwin Eggenberger added a comment - Hi Damien, you are right, my code lacks a $. I've never tested it with URL translation disabled, but regarding the other bug you've just found, rss exports probably were never tested without URL translation before If you are worried about the SEO impact of using the system URL, you can set isPermaLink="false" and use just the ID. See http://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt You could also redirect system URLs to the translated urls. But to be honest, I'm also not sure what would be best to use as guid. Our problem was that our readers got duplicate entries in their news aggregators, and using the translated URL as guid didn't solve this problem. Using the node ID works fine for us, since our rss exports use only one source and we don't use multiple locations for objects. Regards, Erwin
          Hide
          Geir Arne Waaler added a comment -

          The enhancement has been implemented. I move it to Closed.

          Show
          Geir Arne Waaler added a comment - The enhancement has been implemented. I move it to Closed.

            People

            • Assignee:
              Ole Morten Halvorsen
              Reporter:
              Damien Pobel
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: